Skip to content

Commit

Permalink
Fix skinny buttons (#336)
Browse files Browse the repository at this point in the history
# What's Changed?

- Fixed skinny buttons and tabs that were broken by changes to touch
area in #330

## Screenshots

### Before
<img width="1385" alt="Screenshot 2023-01-16 at 14 21 39"
src="https://user-images.githubusercontent.com/88904316/212700049-7384768a-5119-4a13-83c2-db71d347ce44.png">

### After
<img width="1141" alt="Screenshot 2023-01-16 at 14 22 21"
src="https://user-images.githubusercontent.com/88904316/212700189-b347b140-8833-4cdd-9764-5692118c69d8.png">

closes #335

Co-authored-by: loiswells97 <loiswells97@users.noreply.github.com>
Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Co-authored-by: Lois Wells <88904316+loiswells97@users.noreply.github.com>
Co-authored-by: Patrick Cherry <patch0@users.noreply.github.com>
  • Loading branch information
5 people committed Jan 16, 2023
1 parent 4c5ae32 commit 65e2f49
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Fixed
- Make sure button text is always centered (#328)
- Touch area of icon-only buttons (#330, #336)
- Delete project action on project index page (#330)
- Refactored project list loading to allow loading states to be shown (#330)
- Touch area of icon-only buttons (#330)
- Removed unneeded scrollbars on the editor and output panels (#331)
- Make Your projects page background extend below the fold (#334)

Expand Down
5 changes: 5 additions & 0 deletions src/components/Button/Button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@
}
}

&--small {
min-height: unset;
min-width: unset;
}

&--svg-only {
svg {
margin: 0;
Expand Down
1 change: 1 addition & 0 deletions src/tabs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ $spacing-four: calc($spacing-eight / 2);

&__tab-inner {
@extend .btn;
@extend .btn--small;
@extend .btn--secondary;

border: 3px solid transparent;
Expand Down

0 comments on commit 65e2f49

Please sign in to comment.