Fix web-component boolean attributes (#881)

Fix so anything other than explicitly setting the boolean attributes as false is taken as true
RaspberryPiFoundation · Jan 11, 2024 · dff625e · dff625e
1 parent f2c2490
commit dff625e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ### Fixed
 
+- Boolean web component attributes (#881)
 - Wrap the project bar when sidebar is wide (#869)
 - Web component project bar state update delay (#869)
 - Left border of the project bar (#869)

diff --git a/src/web-component.js b/src/web-component.js
@@ -58,7 +58,7 @@ class WebComponent extends HTMLElement {
         name,
       )
     ) {
-      value = newVal === "true";
+      value = newVal !== "false";
     } else if (
       ["instructions", "sidebar_options", "host_styles"].includes(name)
     ) {