Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaking height proportion of visual and text output #187

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Tweaking height proportion of visual and text output #187

merged 2 commits into from
Sep 13, 2022

Conversation

loiswells97
Copy link
Contributor

What's Changed?

Made the height of the visual tab 70% of the total player height instead of 50% so the player fits the p5 canvases better

Before (standard browser height of my laptop screen)

Screenshot 2022-09-12 at 18 14 08

After

Screenshot 2022-09-12 at 18 13 44

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-ui-pi-player-hei-nofzrs September 13, 2022 09:26 Inactive
patch0
patch0 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changelog entry 👍

@github-actions
Copy link

@loiswells97 loiswells97 merged commit 82555a6 into main Sep 13, 2022
@patch0 patch0 deleted the player-height-tweak branch March 27, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patch0 patch0 patch0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loiswells97 @patch0 @raspberrypiherokubot