Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in translatable strings to UI interface #253

Merged
merged 13 commits into from
Nov 4, 2022
Merged

Add in translatable strings to UI interface #253

merged 13 commits into from
Nov 4, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Oct 27, 2022 •
edited by loiswells97
Loading

What's Changed?

  • In the UI hopefully nothing
  • Replaced hardcoded text with translatable strings throughout the editor site, with translations currently located in src/i18n.js

closes #226

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 27, 2022 15:27 Inactive
@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 28, 2022 10:56 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 28, 2022 11:14 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 28, 2022 13:39 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 28, 2022 14:43 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 28, 2022 14:45 Inactive
@github-actions
Copy link

@github-actions
Copy link

@loiswells97
Copy link
Contributor

Some questions about this:

  1. Do we want to translate the Astro Pi component?
  2. How are we going to organise the translations when the web component cannot make requests to the public directory?

@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 31, 2022 11:40 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 31, 2022 11:51 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 31, 2022 11:56 Inactive
@loiswells97 loiswells97 marked this pull request as ready for review October 31, 2022 11:59
@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface October 31, 2022 12:18 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/226-Add_in_translatable_strings_to_UI_interface November 4, 2022 16:41 Inactive
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@sHtev sHtev enabled auto-merge (squash) November 4, 2022 17:38
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@sHtev sHtev merged commit 89d91ce into main Nov 4, 2022
@sHtev sHtev deleted the issues/226-Add_in_translatable_strings_to_UI_interface branch November 4, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sHtev sHtev sHtev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add in translatable strings to UI interface
2 participants
@loiswells97 @sHtev