Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyboard navigation #375

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Fix keyboard navigation #375

merged 4 commits into from
Mar 3, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #371

@create-issue-branch create-issue-branch bot temporarily deployed to previews/a11y/371-Fix_keyboard_navigation February 20, 2023 12:24 Inactive
@github-actions
Copy link

@github-actions
Copy link

@chrisruk chrisruk temporarily deployed to previews/a11y/371-Fix_keyboard_navigation February 21, 2023 10:32 — with GitHub Actions Inactive
@github-actions
Copy link

@chrisruk chrisruk temporarily deployed to previews/a11y/371-Fix_keyboard_navigation February 22, 2023 13:44 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@chrisruk chrisruk temporarily deployed to previews/a11y/371-Fix_keyboard_navigation February 24, 2023 10:38 — with GitHub Actions Inactive
@github-actions
Copy link

@chrisruk chrisruk force-pushed the a11y/371-Fix_keyboard_navigation branch from f35abca to 36791fa Compare March 3, 2023 11:13
@chrisruk chrisruk temporarily deployed to previews/a11y/371-Fix_keyboard_navigation March 3, 2023 11:13 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

@chrisruk chrisruk force-pushed the a11y/371-Fix_keyboard_navigation branch from 36791fa to fe922c8 Compare March 3, 2023 11:26
@chrisruk chrisruk temporarily deployed to previews/a11y/371-Fix_keyboard_navigation March 3, 2023 11:26 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

@chrisruk chrisruk force-pushed the a11y/371-Fix_keyboard_navigation branch from fe922c8 to bfeec80 Compare March 3, 2023 11:35
@chrisruk chrisruk temporarily deployed to previews/a11y/371-Fix_keyboard_navigation March 3, 2023 11:35 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

@chrisruk chrisruk marked this pull request as ready for review March 3, 2023 11:41
IzzySmillie
IzzySmillie requested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@IzzySmillie IzzySmillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change otherwise looks good :)

We should probably refactor the button component a bit so the settings would also work with it but as these are being moved to a different place later anyway, think it's all good!

CHANGELOG.md Show resolved Hide resolved
@chrisruk chrisruk force-pushed the a11y/371-Fix_keyboard_navigation branch from bfeec80 to f479381 Compare March 3, 2023 11:57
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

IzzySmillie
IzzySmillie approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@IzzySmillie IzzySmillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@chrisruk chrisruk merged commit cc445b0 into main Mar 3, 2023
@chrisruk chrisruk deleted the a11y/371-Fix_keyboard_navigation branch March 3, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisruk chrisruk chrisruk left review comments

@IzzySmillie IzzySmillie IzzySmillie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix keyboard navigation
2 participants
@IzzySmillie @chrisruk