Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace margin physical properties with logical #717

Merged
merged 15 commits into from Nov 17, 2023
Merged

Replace margin physical properties with logical #717

merged 15 commits into from Nov 17, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #716

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical October 23, 2023 07:50 Inactive
@github-actions
Copy link

@github-actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical October 23, 2023 07:54 — with GitHub Actions Inactive
@github-actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical October 23, 2023 08:51 — with GitHub Actions Inactive
@github-actions
Copy link

@magdalenajadach magdalenajadach mentioned this pull request Oct 23, 2023
Closed
@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical October 23, 2023 14:47 — with GitHub Actions Inactive
@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical October 23, 2023 14:48 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@magdalenajadach magdalenajadach marked this pull request as ready for review October 24, 2023 08:27
@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical October 31, 2023 10:30 — with GitHub Actions Inactive
@github-actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical November 8, 2023 16:48 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

@loiswells97
Copy link
Contributor

Taken a brief look at this, and my initial thought is, do we need to switch to logical properties in the cases where there is symmetry? For instance margin: 0, or even margin: var1, var2? Maybe we do need to change the second one if there are any cases where we would want to switch from horizontal to vertical... But I think the first example should be fine in any case 🤔

@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical November 15, 2023 09:32 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical November 17, 2023 10:09 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical November 17, 2023 13:58 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/issues/716-Replace_margin_physical_properties_with_logical November 17, 2023 15:14 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

PetarSimonovic
PetarSimonovic reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@PetarSimonovic PetarSimonovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small query Magda - looks great!

src/assets/stylesheets/ContextMenu.scss Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

PetarSimonovic
PetarSimonovic approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@PetarSimonovic PetarSimonovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@magdalenajadach magdalenajadach merged commit 1db7b71 into main Nov 17, 2023
8 checks passed
@magdalenajadach magdalenajadach deleted the issues/716-Replace_margin_physical_properties_with_logical branch November 17, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetarSimonovic PetarSimonovic PetarSimonovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility: Replace margin physical properties with logical
3 participants
@loiswells97 @PetarSimonovic @magdalenajadach