Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow themes to be set and toggled globally #752

Merged
merged 1 commit into from Nov 15, 2023
Merged

Conversation

sra405
Copy link
Contributor

@sra405 sra405 commented Nov 14, 2023

Adds a toolbar item that then wraps the story in the classes needed to theme the editor in light or dark mode.

Screen.Recording.2023-11-14.at.17.27.32.mov

Copy link

Copy link
Contributor

@PetarSimonovic PetarSimonovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@@ -60,3 +63,17 @@ export const parameters = {
states: [],
},
};

export const globalTypes = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to know about this. Seems very straightforward and could be really useful in the future for implementing all sorts of custom controls (eg, I think Storybook has it's own responsiveness sizes that might not align with ours)

@sra405 sra405 merged commit 0f5f19a into main Nov 15, 2023
7 of 8 checks passed
@sra405 sra405 deleted the allow-storybook-theming branch November 15, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants