Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set breakpoints on container not media query #776

Merged
merged 2 commits into from Nov 23, 2023

Conversation

sra405
Copy link
Contributor

@sra405 sra405 commented Nov 22, 2023

Related to #708 and fixes input/output panel breakpoints when web component is positioned on a page that doesn't take the full width of the screen

Currently the breakpoints change as a result of the positioning of the web component on the page e.g. if additional margin is added around the web component the breakpoints will be effected

Screen.Recording.2023-11-22.at.11.08.13.mov

Copy link

Copy link

Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@sra405 sra405 merged commit 33fbbb3 into main Nov 23, 2023
8 checks passed
@sra405 sra405 deleted the fix/web-component-breakpoints branch November 23, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants