Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Linter issues with the border, width etc. #787

Merged
merged 17 commits into from Dec 15, 2023
Merged

Accessibility: Linter issues with the border, width etc. #787

merged 17 commits into from Dec 15, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #786

@create-issue-branch create-issue-branch bot temporarily deployed to previews/a11y/786-Accessibility_Linter_issues_with_the_border_width_etc November 24, 2023 16:20 Inactive
@magdalenajadach
Merge branch 'a11y/769-Explore_logical_properties_as_a_linter_rule' i…
89afaa4 
…nto a11y/786-Accessibility_Linter_issues_with_the_border_width_etc
@magdalenajadach magdalenajadach temporarily deployed to previews/a11y/786-Accessibility_Linter_issues_with_the_border_width_etc November 24, 2023 16:21 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/a11y/786-Accessibility_Linter_issues_with_the_border_width_etc November 24, 2023 16:44 — with GitHub Actions Inactive
@magdalenajadach magdalenajadach temporarily deployed to previews/a11y/786-Accessibility_Linter_issues_with_the_border_width_etc November 24, 2023 16:53 — with GitHub Actions Inactive
@magdalenajadach magdalenajadach self-assigned this Nov 27, 2023
@magdalenajadach magdalenajadach marked this pull request as ready for review November 27, 2023 15:44
@magdalenajadach magdalenajadach temporarily deployed to previews/a11y/786-Accessibility_Linter_issues_with_the_border_width_etc November 27, 2023 15:47 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/a11y/786-Accessibility_Linter_issues_with_the_border_width_etc December 14, 2023 10:48 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/a11y/786-Accessibility_Linter_issues_with_the_border_width_etc December 14, 2023 13:36 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@magdalenajadach magdalenajadach temporarily deployed to previews/a11y/786-Accessibility_Linter_issues_with_the_border_width_etc December 14, 2023 13:43 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

sra405
sra405 reviewed Dec 14, 2023
View reviewed changes
.stylelintrc
"stylelint-scss"
],
"extends": ["stylelint-config-recommended-scss"],
"plugins": ["stylelint-scss", "stylelint-use-logical"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylelint-use-logical looks like a really useful plugin, one to keep an eye on but it doesn't look particularly active or highly used. We've got much worse dependencies than this in the projects site we need to sort but might be worth checking to see if other options are around

sra405
sra405 reviewed Dec 14, 2023
View reviewed changes
src/assets/stylesheets/Sidebar.scss Outdated
@@ -86,7 +86,7 @@
&--selected {
background-color: var(--sidebar-panel-background);
border-radius: $space-0-5 0 0 $space-0-5;
border-block: 1px solid var(--sidebar-border);
border: 1px solid var(--sidebar-border);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why change this from border-block?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's post-merge bug, fixed. Thank you

@github-actions GitHub Actions
Copy link

sra405
sra405 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@sra405 sra405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks and works great 🥳

@magdalenajadach magdalenajadach merged commit 83427fc into main Dec 15, 2023
8 checks passed
@magdalenajadach magdalenajadach deleted the a11y/786-Accessibility_Linter_issues_with_the_border_width_etc branch December 15, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magdalenajadach magdalenajadach magdalenajadach left review comments

@sra405 sra405 sra405 approved these changes

Assignees

@magdalenajadach magdalenajadach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility: Linter issues with the border, width etc.
2 participants
@magdalenajadach @sra405