Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code block instructions styling #794

Merged
merged 5 commits into from Dec 4, 2023
Merged

Code block instructions styling #794

merged 5 commits into from Dec 4, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #765

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/765-Code_block_instructions_styling November 27, 2023 12:26 Inactive
@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/765-Code_block_instructions_styling December 1, 2023 17:23 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/765-Code_block_instructions_styling December 1, 2023 17:24 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

@loiswells97 loiswells97 temporarily deployed to previews/issues/765-Code_block_instructions_styling December 4, 2023 12:19 — with GitHub Actions Inactive
@loiswells97 loiswells97 marked this pull request as ready for review December 4, 2023 12:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

PetarSimonovic
PetarSimonovic reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@PetarSimonovic PetarSimonovic left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the title needs to be an optional part of the codeblock

@loiswells97
Copy link
Contributor

It looks like the title needs to be an optional part of the codeblock

I think it is... As in, if you don't include a title in the markdown it looks like it does in the designs without a title
Screenshot 2023-12-04 at 14 30 56

PetarSimonovic
PetarSimonovic approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@PetarSimonovic PetarSimonovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

src/assets/stylesheets/Instructions.scss
background-color: $rpf-grey-700;
}

.c-project-code__heading {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will allow us to style the title/heading as in the design docs?

Design doc:
image

Current codeblock in draft project
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I think this one just hasn't been set up in the markdown

@loiswells97 loiswells97 merged commit d30abcd into main Dec 4, 2023
8 checks passed
@loiswells97 loiswells97 deleted the issues/765-Code_block_instructions_styling branch December 4, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loiswells97 loiswells97 loiswells97 left review comments

@PetarSimonovic PetarSimonovic PetarSimonovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code block instructions styling
3 participants
@loiswells97 @PetarSimonovic @magdalenajadach