Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web component toasts #822

Merged
merged 8 commits into from Dec 18, 2023
Merged

Web component toasts #822

merged 8 commits into from Dec 18, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #813

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/813-Web_component_toasts December 12, 2023 14:43 Inactive
@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/813-Web_component_toasts December 13, 2023 13:34 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@loiswells97 loiswells97 marked this pull request as ready for review December 13, 2023 13:45
@loiswells97 loiswells97 temporarily deployed to previews/issues/813-Web_component_toasts December 13, 2023 13:45 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/813-Web_component_toasts December 15, 2023 13:16 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/813-Web_component_toasts December 15, 2023 13:56 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

PetarSimonovic
PetarSimonovic reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@PetarSimonovic PetarSimonovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a console log Lois!

src/hooks/useProjectPersistence.js Outdated
@@ -39,6 +39,7 @@ export const useProjectPersistence = ({
}, [saveTriggered, project, user, dispatch]);

useEffect(() => {
console.log(project, user, justLoaded, hasShownSavePrompt);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this console.log now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I missed this, have removed 👍

PetarSimonovic
PetarSimonovic approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@PetarSimonovic PetarSimonovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@github-actions GitHub Actions
Copy link

@loiswells97 loiswells97 merged commit 081d8c5 into main Dec 18, 2023
8 checks passed
@loiswells97 loiswells97 deleted the issues/813-Web_component_toasts branch December 18, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loiswells97 loiswells97 loiswells97 left review comments

@PetarSimonovic PetarSimonovic PetarSimonovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web component toasts
2 participants
@PetarSimonovic @loiswells97