New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme not correctly applied to sidebar tab #886
Merged
sra405
merged 6 commits into
main
from
a11y/874-Theme_not_correctly_applied_to_sidebar_tab
Feb 19, 2024
Merged
Theme not correctly applied to sidebar tab #886
sra405
merged 6 commits into
main
from
a11y/874-Theme_not_correctly_applied_to_sidebar_tab
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create-issue-branch
bot
temporarily deployed
to
previews/a11y/874-Theme_not_correctly_applied_to_sidebar_tab
January 12, 2024 15:49
Inactive
|
|
…er on selected sidebar options
sra405
temporarily deployed
to
previews/a11y/874-Theme_not_correctly_applied_to_sidebar_tab
January 16, 2024 15:41
— with
GitHub Actions
Inactive
|
|
sra405
temporarily deployed
to
previews/a11y/874-Theme_not_correctly_applied_to_sidebar_tab
January 16, 2024 15:43
— with
GitHub Actions
Inactive
|
conorriches
reviewed
Jan 16, 2024
const buttonClass = `btn${className ? ` ${className}` : ""}${ | ||
buttonText ? "" : " btn--svg-only" | ||
}`; | ||
const buttonClass = classNames("btn", className, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yesssssss nice
conorriches
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
loiswells97
temporarily deployed
to
previews/a11y/874-Theme_not_correctly_applied_to_sidebar_tab
February 16, 2024 16:42
— with
GitHub Actions
Inactive
|
|
sra405
deleted the
a11y/874-Theme_not_correctly_applied_to_sidebar_tab
branch
February 19, 2024 16:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #874