AstroPi - hide save popup/toast #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
create-issue-branch
bot
temporarily deployed
to
previews/issues/953-AstroPi_-_hide_save_popup/toast
loiswells97
temporarily deployed
to
previews/issues/953-AstroPi_-_hide_save_popup/toast
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/issues/953-AstroPi_-_hide_save_popup/toast
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/issues/953-AstroPi_-_hide_save_popup/toast
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/issues/953-AstroPi_-_hide_save_popup/toast
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/issues/953-AstroPi_-_hide_save_popup/toast
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/issues/953-AstroPi_-_hide_save_popup/toast
GitHub Actions
Inactive
|
|
sra405
reviewed
Mar 15, 2024
| @@ -86,7 +86,7 @@ describe("When no user is in state", () => { | |||
| project: { | |||
| components: [], | |||
| }, | |||
| hasShownSavePrompt: false, | |||
| hasShownSavePrompt: true, | |||
There was a problem hiding this comment.
I'm not sure why this has been changed 🤔 hasShownSavePrompt should stay as it was and with showSavePrompt defaulting to false these tests should work without change unless I'm missing something
There was a problem hiding this comment.
I guess it's because we're now defaulting to not showing the save prompt, so the change on line 109 of WebComponentLoader means that we're passing this in as true to stop the prompt from showing unless they've specified that they want it... Maybe the naming is not the best though?
There was a problem hiding this comment.
AH Sorry!! I thought this was setting state, I should've checked the few lines above. Yea absolutely, that's fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #953