Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set met and metplus environmental variables in run_vx.local.lua modulefiles #1

Conversation

natalie-perlin
Copy link

@natalie-perlin natalie-perlin commented Sep 24, 2023

DESCRIPTION OF CHANGES:

Set environmental variables for met and metplus modules in ./modulefiles/tasks//run_vx.local.lua . These variables are present in hpc-stack modulefiles and are not defined in spack-stack modulefiles.
is a specific platform, i.e., hera, gaea, orion, jet, noaacloud, cheyenne/derecho.

Files changed:
./modulefiles/tasks/orion/run_vx.local.lua
./modulefiles/tasks/hera/run_vx.local.lua
./modulefiles/tasks/gaea/run_vx.local.lua
./modulefiles/tasks/cheyenne/run_vx.local.lua
./modulefiles/tasks/jet/run_vx.local.lua
./modulefiles/tasks/derecho/run_vx.local.lua
./ush/machine/orion.yaml

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

Four met verifications tests were run on Orion with hpc-stack and spack-stack, with similar run_vx.local.lua (all similar except for the module versions).

Spack-stack:

All 4 experiments finished
Calculating core-hour usage and printing final summary
----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
MET_verification                                                   COMPLETE              11.86
MET_verification_only_vx                                           COMPLETE               0.25
MET_ensemble_verification                                          COMPLETE              21.91
MET_ensemble_verification_only_vx                                  COMPLETE               1.05
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE              35.07

Detailed summary written to /work/noaa/epic/nperlin/SRW/expt_dirs/spack/WE2E_summary_20230924073715.txt

With hpc-stack:

All 4 experiments finished
Calculating core-hour usage and printing final summary
----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
MET_verification                                                   COMPLETE              10.12
MET_verification_only_vx                                           COMPLETE               0.15
MET_ensemble_verification                                          COMPLETE              19.17
MET_ensemble_verification_only_vx                                  COMPLETE               0.89
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE              30.33
Detailed summary written to /work/noaa/epic/nperlin/SRW/expt_dirs/hpc/WE2E_summary_20230924073905.txt
  • hera.intel
  • orion.intel (with spack-stack)
  • orion.intel (with hpc-stack)
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

ufs-community#905
ufs-community#901 (merged)
ufs-community#913

DOCUMENTATION:

ISSUE:

Use of Met and Metplus modules built with spack-stack/1.4.1 need additional environmental variables to be used by the SRW. These additional variables were present in met and metplus modules built with hpc-stack.

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug (currently for noaacloud)
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@RatkoVasic-NOAA RatkoVasic-NOAA merged commit 8ed5551 into RatkoVasic-NOAA:srw_spack-stack Sep 25, 2023
@natalie-perlin natalie-perlin deleted the develop_spack_stack branch October 13, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants