Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Get the tests passing #7

Merged
merged 8 commits into from
Aug 27, 2015
Merged

WIP Get the tests passing #7

merged 8 commits into from
Aug 27, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2015

The tests suite currently doesn't pass because the components don't render as the text examples stand.

We want to get to a point where the tests are green, which either involves:

  1. deleting the tests,
  2. fudging the component syntax to be correctly invoked in the tests, or
  3. getting the component tests to actually do something meaningful.

I don't mind too much which we go for as long as we do one of them. I've made a start doing 2 here.

@spencer516
Copy link
Contributor

Yea, I think that 2 is good for a start.

I'd like to get to 3, but I think that this requires some thought. (Especially with rendering to canvas...not really sure the best way to approach that).

Spencer added 2 commits August 20, 2015 11:18
This can/should be expanded upon...but at least gets our basic tests passing for now.
@spencer516
Copy link
Contributor

@bdvholmes — thought I'd finish this one up...I think our build should finally pass. Let me know if you think this is good to merge.

@spencer516
Copy link
Contributor

Well, we're passing for 1.13...not for Ember 2.0 / 2.1 beta. Maybe not quite ready to merge then. ;-)

@ghost
Copy link
Author

ghost commented Aug 20, 2015

Sweet :-)

@spencer516
Copy link
Contributor

Finally got around to getting these tests passing in 2.0 & 2.1 Beta. Assuming Travis builds pass, I'll merge this.

spencer516 added a commit that referenced this pull request Aug 27, 2015
@spencer516 spencer516 merged commit e2d8f49 into master Aug 27, 2015
@spencer516 spencer516 deleted the feature/tests_passing branch August 27, 2015 21:07
@ghost
Copy link
Author

ghost commented Aug 27, 2015

Splendid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant