refactor entity and xml_payload #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you very much for reviewing! I will look at this in more detail tomorrow, from a first glance it seems really good. the problem with the #TODOs is, that they are mostly referencing the problems in the current federation implementation, like fields that don't make sense or stuff that is missing. There should be some discussion about how to handle those issues best, also keeping in mind backward-compatibility... |
|
@Raven24 I see, I'll try to take a look at the #TODO's when I have more time |
Raven24
added a commit
that referenced
this pull request
Sep 12, 2013
refactor entity and xml_payload
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, this is an awesome work!
While reviewing this some rafactors came up, I still have to take a look at some parts of the code, I'm not that familiar with Diaspora's federation, but I'm still learning!
I notice that there are some #TODOs in the code, I can work on them if you like, but probably I'm goning to need some help to understand what is needed to be changed.