Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge procedure can lead to mistakes on master #253

Open
rptb1 opened this issue Jun 17, 2023 · 0 comments
Open

Merge procedure can lead to mistakes on master #253

rptb1 opened this issue Jun 17, 2023 · 0 comments
Assignees
Labels
critical Will cause failure of the entire project process To do with process or procedure

Comments

@rptb1
Copy link
Member

rptb1 commented Jun 17, 2023

@thejayps accidentally made commits with incorrect messages on master by following proc.merge.pull-request because he committed after resolving conflicts, not realising that would commit to master.

We can make three improvements:

  1. We could encourage the use of catch-up merges from master to resolve conflict.
  2. We can warn people not to commit when resolving conflicts from the merge until they are tested, since this changes master.
  3. We could tell people to eyeball the log of master before pushing, e.g. with git log -n 3 --first-parent master
@rptb1 rptb1 added the process To do with process or procedure label Jun 17, 2023
@thejayps thejayps added the critical Will cause failure of the entire project label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Will cause failure of the entire project process To do with process or procedure
Projects
None yet
Development

No branches or pull requests

3 participants