Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compass Error in instances #32

Open
arieh opened this issue Mar 15, 2019 · 3 comments
Open

Compass Error in instances #32

arieh opened this issue Mar 15, 2019 · 3 comments
Labels
question Further information is requested

Comments

@arieh
Copy link

arieh commented Mar 15, 2019

Compass.lua#31 - seems like GetPlayerFacing() might return nil

I solved it by doing

        local angle = 0
	local facing = GetPlayerFacing() or 0

	if rotateMinimap == "1" then
		angle = -facing or angle
	end
@Ravendwyr
Copy link
Owner

Looks like they changed how maths works and we can't have negative nil any more. 😛
Oh well.

@Ravendwyr
Copy link
Owner

...or they simply made GetPlayerFacing() not work at all in dungeons. Welp.

Ravendwyr pushed a commit that referenced this issue Mar 15, 2019
See #32

Co-Authored-By: Arieh Glazer <arieh@arieh.co.il>
@arieh
Copy link
Author

arieh commented Mar 29, 2019

I think it's negative nil since the rotating map still works reliably - i think they have some rate limiting or something like that. it just sometimes returns nil instead of 0

@Ravendwyr Ravendwyr added question Further information is requested and removed Accepted labels Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants