Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest Tracker repositions itself on various events #36

Open
CommanderAngry opened this issue Jun 30, 2019 · 3 comments · May be fixed by #57
Open

Quest Tracker repositions itself on various events #36

CommanderAngry opened this issue Jun 30, 2019 · 3 comments · May be fixed by #57
Labels
question Further information is requested

Comments

@CommanderAngry
Copy link

Running the latest version of Chinchilla and the Quester mod (to unlock and reposition the tracking window) only. No other mods installed. Various events such as summoning a mount, transitioning between zones or areas (I just tested this in Dalaran, transitioning between the bank and the steps outside) cause the tracking window to reposition itself back to the default position set by Chinchilla. No errors are displayed on screen.

This seems similar to closed issue #23, where you mention that it could be due to Blizzard's dodgy action bar code. Note that this happens with or without the 'enable' button checked in the Chinchilla configuration screen. This isn't a show-stopper by any means, it's just annoying as hell. If you need it characterized further, let me know and I'll do some additional testing.

@Ravendwyr
Copy link
Owner

Ravendwyr commented Jun 30, 2019

Aye, the two addons are conflicting with each other. Both of them are trying to reposition the quest tracker and it looks like Chinchilla is winning.

I'm assuming you mean the Enable button in the Quest Tracker module of the config? Unfortunately that won't help as the quest tracker's position is handled by the Position module and disabling this will reset any other frame you've moved with this method. It might be an idea to let Chinchilla handle the positioning rather than Quester for now if you like Quester's other features.

I'm still arguing with myself how best to tackle this. My current ideas are:

  1. Remove all quest tracker code entirely in favour of recommending addons like Quester.
  2. Move all quest tracker code back to the Quest Tracker module.
  3. Allow individual frames be enabled or not to theoretically prevent conflicts in the (eventual) rewrite of the Position module.

@CommanderAngry
Copy link
Author

It does indeed appear to be a conflict of interest between the two mods. Chinchilla updates the position to its configurated position (in this case, it's the default anchor to the bottom of the mini map). Quester happily unlocks the windows and allows me to move it around, but Chinchilla moves it back to where it believes it should be on updates.

Yeah I was referring to the Enable button in the Quest Tracker configuration for Chinchilla. From a user perspective, it seemed logical that disabling that would tell Chinchilla "Ok, don't do that". :) Having all the configuration options for particular things makes sense from a user's perspective, but from a project standpoint, I can certainly understand organizing it by functional groups.

From my point of view, I don't think tearing up the code is necessary - if you could add an if/else clause to the update position section to exclude the quest tracker window for updates, that may be a simple solution. That would effectively allow users to run other mods that move the Quest Tracker window around without Chinchilla overriding their selections while still allowing users the option of letting Chinchilla manage it if they so choose. But I haven't looked at the organization of the code as it stands, so I can't give you much feedback other than the suggestion above.

@Ravendwyr Ravendwyr added the question Further information is requested label Sep 20, 2019
@stoglim
Copy link
Contributor

stoglim commented Oct 18, 2020

As this appears to be two addons fighting for positioning of Quest Log, and Chinchilla already has the option to disable the Quest Tracker perhaps simply just adding additional information to the Quest Tracker configuration indicating that enabling Quest Tracker has known issues playing nicely with other Quest Log addons and should be disabled in that case.
Checking for all known and/or unknown movers of the Quest Log seems overly cumbersome.

stoglim added a commit to stoglim/Chinchilla that referenced this issue Oct 19, 2020
Ravendwyr#36

Should be able to disable quest tracker to prevent this behavior
@Ravendwyr Ravendwyr added this to the v2.11 milestone Oct 22, 2020
@Ravendwyr Ravendwyr removed this from the v2.11.x milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Positions Module Overhaul
  
Needs triage
Development

Successfully merging a pull request may close this issue.

3 participants