Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Position from moving quest tracker if it is not enabled #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Modules/Position.lua
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ function Position:OnEnable()

-- in alphabetical order, as they should be
self:SetFramePosition('durability')
self:SetFramePosition('questWatch')
if((Chinchilla:GetModule("QuestTracker", true) and Chinchilla:GetModule("QuestTracker"):IsEnabled())) then
self:SetFramePosition('questWatch')
end
self:SetFramePosition('ticketStatus')

if not Chinchilla:IsClassic() then
Expand Down Expand Up @@ -196,7 +198,9 @@ function Position:OnDisable()

-- in alphabetical order, as they should be
self:SetFramePosition('durability')
self:SetFramePosition('questWatch')
if((Chinchilla:GetModule("QuestTracker", true) and Chinchilla:GetModule("QuestTracker"):IsEnabled())) then
self:SetFramePosition('questWatch')
end
self:SetFramePosition('ticketStatus')

if not Chinchilla:IsClassic() then
Expand Down Expand Up @@ -726,7 +730,7 @@ function Position:GetOptions()
disabled = InCombatLockdown,
} or nil,
questWatch = nameToFrame["questWatch"] and {
name = L["Quest and achievement tracker"],
name = L["Quest and achievement tracker. Moving this element is disabled if Quest Tracker module is disabled."],
desc = L["Position of the quest/achievement tracker on the screen"],
type = 'group',
inline = true,
Expand All @@ -738,6 +742,7 @@ function Position:GetOptions()
order = 1,
get = movable_get,
set = movable_set,
disabled = not ((Chinchilla:GetModule("QuestTracker", true) and Chinchilla:GetModule("QuestTracker"):IsEnabled()))
},
x = {
name = L["Horizontal position"],
Expand Down