Fix for Issue #23 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restarting a System.Windows.Forms.Timer does not always work when using a BackgroundWorker. Added method restartTimer that takes a System.Windows.Forms.Timer and sets it to true from the main thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in Issue #23 RWC stops looking for wallpapers when finding a wallpaper from deviantart and then timing out on the HttpWebRequest that checks whether the url links to an image file.
As far as I can tell, this is due to the Timer breakBetweenChange being restarted in a BackgroundWorker's thread with no effect on the main thread. This commit fixes that by adding a method that invokes a Timer from the main thread.
I replaced all .Enabled = true; calls that were made from DoWork delegates in setWallpaper and changeWallpaper.
I have been running RWC for a few hours now with wallpaper changes every minute and so far I have not noticed any stops in the cycle.
I have not fixed RWC not being able to fetch deviantart wallpapers yet, I leave that to @Rawns ;-)