Added DropDown Functionality in screener screen . RAXAJSS-311 #165
Conversation
| xtype: 'selectfield', | ||
| id: 'topbarSelectfield', | ||
| centered: true , | ||
| value: 'screener' , |
There was a problem hiding this comment.
is screener always the default?
There was a problem hiding this comment.
screener would be the default here, but the listeners below should go into the actual toolbar file (otherwise we would have to add them in manually into each module)
There was a problem hiding this comment.
Oops- yes, value should be "screener" here.
Agreed on moving listeners
There was a problem hiding this comment.
So add all of this into the toptoolbar.js file. We would ideally like to use this in other modules. Make the default value 'login' rather than 'screener', then inside this file, set the value to 'screener'.
| var url = window.location.href; | ||
| var array = url.split('/'); | ||
| var lastsegment = array[array.length-2]; | ||
| if(lastsegment != Ext.getCmp('topbarSelectfield').getValue()) |
There was a problem hiding this comment.
This works fine for an url like src/screener/ but eventually we will have src/screener/#somepageinscreener
Instead of splitting by /, check to see whether the url contains the topbar field value as a substring.
…l splitting , now instead of splitting the url its checking the indexOf the field , that whether it exists or not .
…SS-311 . Change the functionality of code by changing the splitting part of url to indexOf part .
…made the '--" in place of all unreal data , probably some backend work is required in this .
| if(url.indexOf("Dashboard") >= 0) | ||
| { | ||
| if(Ext.getCmp('topbarSelectfield').getValue() == 'patientfacing') { | ||
| value: Ext.getCmp('topbarSelectfield').getValue(); |
There was a problem hiding this comment.
why do you get the value here, but not in any of the other if blocks?
|
@SidhiAgarwal will you have time today to update and merge with the latest code? |
ghost
assigned …SS-311 Changes made to clean up and for latest comment.
…S-311 Changes made to clean up and for latest comment.
…S-311 Changes made to clean up and for latest comment.
…S-311 Changes made to clean up and for latest comment.
|
Looks good, merging. |
Added DropDown Functionality in screener screen . RAXAJSS-311
Modules been dynamically added to the DropDown and changed the text and font of the modules added in the DropDown in Screener screen.