Issue checkstyle#7854: Resolve Pitest Issues - IllegalImportCheck (1)

RayRCaringal · Apr 7, 2020 · 2cf7f28 · 2cf7f28
1 parent 2f142c0
commit 2cf7f28
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.ci/pitest.sh b/.ci/pitest.sh
@@ -72,7 +72,6 @@ pitest-imports)
   mvn -e -P$1 clean test org.pitest:pitest-maven:mutationCoverage;
   declare -a ignoredItems=(
   "CustomImportOrderCheck.java.html:<td class='covered'><pre><span  class='survived'>        if (bestMatch.group.equals(NON_GROUP_RULE_GROUP)) {</span></pre></td></tr>"
-  "IllegalImportCheck.java.html:<td class='covered'><pre><span  class='survived'>        if (regexp) {</span></pre></td></tr>"
   "IllegalImportCheck.java.html:<td class='covered'><pre><span  class='survived'>        if (!result &#38;&#38; illegalClasses != null) {</span></pre></td></tr>"
   "IllegalImportCheck.java.html:<td class='covered'><pre><span  class='survived'>        if (!result) {</span></pre></td></tr>"
   "ImportControlLoader.java.html:<td class='covered'><pre><span  class='survived'>        else if (ALLOW_ELEMENT_NAME.equals(qName) || &#34;disallow&#34;.equals(qName)) {</span></pre></td></tr>"

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheckTest.java
@@ -93,6 +93,20 @@ public void testIllegalClasses()
         verify(checkConfig, getNonCompilablePath("InputIllegalImportDefault.java"), expected);
     }
 
+    @Test
+    public void testIllegalClassesStarImport()
+            throws Exception {
+        final DefaultConfiguration checkConfig =
+            createModuleConfig(IllegalImportCheck.class);
+        checkConfig.addAttribute("illegalClasses", "java.io.*");
+        final String[] expected = {
+            "9:1: " + getCheckMessage(MSG_KEY, "java.io.*"),
+            "15:1: " + getCheckMessage(MSG_KEY, "sun.applet.*"),
+            "28:1: " + getCheckMessage(MSG_KEY, "sun.*"),
+        };
+        verify(checkConfig, getNonCompilablePath("InputIllegalImportDefault.java"), expected);
+    }
+
     @Test
     public void testIllegalPackagesRegularExpression()
             throws Exception {