Book 2 "Ray Intersection with an AABB" needs some editing #1236
Comments
hollasch
added a commit
that referenced
this issue
Aug 25, 2023
In addition, I've changed the way that AABBs are padded. Originally, the primitive constructing an AABB needed to immediately call the aabb::pad() function after construction. Now, the AABB constructors call aabb::pad_to_minimum() automatically to pad any dimension smaller than some delta in size. Resolves #1236
hollasch
added a commit
that referenced
this issue
Aug 30, 2023
In addition, I've changed the way that AABBs are padded. Originally, the primitive constructing an AABB needed to immediately call the aabb::pad() function after construction. Now, the AABB constructors call aabb::pad_to_minimum() automatically to pad any dimension smaller than some delta in size. Resolves #1236
hollasch
added a commit
that referenced
this issue
Aug 30, 2023
In addition, I've changed the way that AABBs are padded. Originally, the primitive constructing an AABB needed to immediately call the aabb::pad() function after construction. Now, the AABB constructors call aabb::pad_to_minimum() automatically to pad any dimension smaller than some delta in size. Resolves #1236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The equations for$t_{x0}$ and $t_{x1}$ appear too late in the text, so the precautionary paragraph above is out of order. I think it would be good to revisit this for flow and clarity.
In addition, this section mentions the new
interval::expand()function, but then doesn't use it.The text was updated successfully, but these errors were encountered: