Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting for changed parts of scene in TheNextWeek #489

Closed
trevordblack opened this issue Apr 19, 2020 · 2 comments
Closed

Highlighting for changed parts of scene in TheNextWeek #489

trevordblack opened this issue Apr 19, 2020 · 2 comments
Assignees
@hollasch
Labels
area: book book 1: One Weekend book 2: Next Week
Milestone
v3.1.1

Comments

@trevordblack
Copy link
Collaborator

trevordblack commented Apr 19, 2020 •
edited
Loading

TheNextWeek.html:290-331

Needs highlighting for changed parts of the scene
@trevordblack trevordblack changed the title TheNextWeek.html:290-331 Highlighting for changed parts of scene in TheNextWeek Apr 19, 2020
@hollasch
Copy link
Collaborator

Not sure if we should be highlighting changes from one book to the prior, but ok. These two code blocks also need to get their styling trued up.

@hollasch hollasch self-assigned this Apr 19, 2020
@hollasch hollasch added this to the v3.0.3 milestone Apr 19, 2020
@hollasch hollasch modified the milestones: v3.0.3, v3.1.1 May 1, 2020
hollasch added a commit that referenced this issue May 6, 2020
@hollasch
Update random_scene() in books 1 and 2
d467cd3 
- Refactored book 1 and 2 `random_scene()` functions. More named
  intermediate values, sync'ed with each other and with source.

- Added highlight for update from random_scene() in book 1.

- Added clarification about updating lambertian variables from `color`
  to `solid_color`.

- Corrected book 2 random_scene() for-loop indices (they differed from
  the version in book 1).

Resolves #489
@hollasch hollasch mentioned this issue May 6, 2020
Merged
@hollasch
Copy link
Collaborator

hollasch commented May 9, 2020

Done.

@hollasch hollasch closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
area: book book 1: One Weekend book 2: Next Week
Projects
None yet
Milestone
v3.1.1
Development

No branches or pull requests
2 participants
@hollasch @trevordblack