Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'STBI_FREE(data);' instead of 'delete data;' in image_texture #734

Closed
longod opened this issue Sep 19, 2020 · 0 comments
Closed

Use 'STBI_FREE(data);' instead of 'delete data;' in image_texture #734

longod opened this issue Sep 19, 2020 · 0 comments
Assignees
@hollasch
Milestone
v3.2.1

Comments

@longod
Copy link

longod commented Sep 19, 2020

Because 'stbi_load' function uses 'STBI_MALLOC'. malloc/free pairs.

Thanks.
@trevordblack trevordblack added this to the v3.2.1 milestone Sep 22, 2020
@trevordblack trevordblack self-assigned this Sep 22, 2020
hollasch added a commit that referenced this issue Sep 30, 2020
@hollasch
Image texture dtor should call STBI_FREE(data)
df68049 
because the `stbi_load` function uses `STBI_MALLOC`.

Resolves #734
@hollasch hollasch mentioned this issue Sep 30, 2020
Merged
@hollasch hollasch assigned hollasch and unassigned trevordblack Sep 30, 2020
@hollasch hollasch closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
None yet
Projects
None yet
Milestone
v3.2.1
Development

No branches or pull requests
3 participants
@hollasch @trevordblack @longod