Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate general quadrilateral object to replace existing axis-aligned rectangles (aarect.h) #756

Closed
hollasch opened this issue Oct 10, 2020 · 1 comment
Closed

Investigate general quadrilateral object to replace existing axis-aligned rectangles (aarect.h) #756

hollasch opened this issue Oct 10, 2020 · 1 comment
Assignees
@hollasch
Labels
area: book area: code book 2: Next Week book 3: Your Life level: major
Milestone
v4.0.0

Comments

@hollasch
Copy link
Collaborator

I'm not convinced that a general quadrilateral object would be much slower than our current axis-aligned rectangle objects. This would replace xy_rect, xz_rect, and yz_rect.
@hollasch hollasch added this to the v3.3.0 milestone Oct 10, 2020
@hollasch hollasch self-assigned this Oct 10, 2020
@hollasch hollasch mentioned this issue Oct 10, 2020
Closed
@hollasch hollasch modified the milestones: v3.3.0, Backlog, v4.0.0 Oct 12, 2020
This was referenced Dec 14, 2020
Closed
Closed
hollasch added a commit that referenced this issue Aug 13, 2021
@hollasch
Revert tri, ellipse, annulus primitives
97e4a73 
This reverts commit b0fbca7b0c6c4e77491b1bbebc6ed5fe939d912e.

Removing these primitives, since we will not be using them. This change
also removes the temporary test scene for quads.

Resolves #292
Resolves #662
Resolves #681
Resolves #756
Resolves #780
@hollasch
Copy link
Collaborator Author

Fixed in ed119af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
area: book area: code book 2: Next Week book 3: Your Life level: major
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@hollasch