Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Book 3 listing 32 creates a light at every ray bounce #759

Closed
hollasch opened this issue Oct 11, 2020 · 1 comment
Closed

Book 3 listing 32 creates a light at every ray bounce #759

hollasch opened this issue Oct 11, 2020 · 1 comment
Assignees
@hollasch
Milestone
v3.2.2

Comments

@hollasch
Copy link
Collaborator

See light_shape variable.
@hollasch hollasch added this to the v3.2.2 milestone Oct 11, 2020
@hollasch hollasch self-assigned this Oct 11, 2020
hollasch added a commit that referenced this issue Oct 12, 2020
@hollasch
Untested: ray_color takes in lights
2710a1d 
The prior code had multiple implementations of `ray_color()` that
created a new light on every ray bounce. This change now passes in the
light shape from the scene.

NOTE: This change is untested. We have big changes pending for book
three when we begin v4.0.0 development soon, so I expect that this code
will be heavily modified (and tested) at that time.

Resolves #759
@hollasch
Copy link
Collaborator Author

Oops, made this change directly in dev-patch: 2710a1d

Taking review comments directly in the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
None yet
Projects
None yet
Milestone
v3.2.2
Development

No branches or pull requests
1 participant
@hollasch