Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book 3 Ray Tracing For The Rest of Your Life-Listing 11 #831

Closed
kyamant opened this issue Dec 11, 2020 · 7 comments
Closed

Book 3 Ray Tracing For The Rest of Your Life-Listing 11 #831

kyamant opened this issue Dec 11, 2020 · 7 comments
Assignees
Milestone

Comments

@kyamant
Copy link

kyamant commented Dec 11, 2020

In the third book Ray Tracing For The Rest of Your Life, listing 11 for material.h has:

scattered = ray(rec.p, unit_vector(direction), r_in.time());

the variable direction was not declared.

@trevordblack
Copy link
Collaborator

I'm on it, thank you

@trevordblack trevordblack self-assigned this Dec 11, 2020
@trevordblack trevordblack added this to the v4.0.0 milestone Dec 11, 2020
@hollasch
Copy link
Collaborator

@trevordblack — let's throw this on dev-patch.

@trevordblack
Copy link
Collaborator

Well. It's in the changes I literally just created a PR for.........

@hollasch
Copy link
Collaborator

You, sir, have ruined everything.

No worries, keep it in dev-major, and I'll cherry-pick into v.3.2.4.

@trevordblack
Copy link
Collaborator

sure
sure sure sure

@trevordblack
Copy link
Collaborator

Can I close out this issue?

hollasch added a commit that referenced this issue Apr 13, 2021
Used variable `direction` when it should have been `scatter_direction`.
@hollasch
Copy link
Collaborator

Hmmm, looks like v3.2.4 ain't happening; I'd forgotten whether this was true and had to check. There's nothing on dev-patch. Let's just say this is fixed in dev-major.

Added an entry to CHANGELOG, as the only change in #884.

hollasch added a commit that referenced this issue Apr 14, 2021
CHANGELOG += #831: book3 listing 11 fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants