Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in one dimensional MC integration #461

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Fix error in one dimensional MC integration #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ Change Log -- Ray Tracing in One Weekend
- Fix: Introduce `u`,`v` surface coordinates to `hit_record` (#441)
- Fix: Add highlight to new `hittable::bounding_box()` method (#442)

### _The Rest of Your Life_
- Fix: unitialized variable in first version of `integrate_x_sq.cc`
- Fix: remove unreferenced variables in several sample programs
- Fix: correct program computation of the integral of x^2 (#438)


----------------------------------------------------------------------------------------------------
# v3.0.1 (2020-03-31)
Expand Down
12 changes: 2 additions & 10 deletions books/RayTracingTheRestOfYourLife.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,16 +221,14 @@
#include <stdlib.h>

int main() {
int inside_circle = 0;
int inside_circle_stratified = 0;
int N = 1000000;
double sum;
auto sum = 0.0;
for (int i = 0; i < N; i++) {
auto x = random_double(0,2);
sum += x*x;
}
std::cout << std::fixed << std::setprecision(12);
std::cout << "I = " << sum/N << '\n';
std::cout << "I = " << 2 * sum/N << '\n';
}
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[Listing [integ-xsq-1]: <kbd>[integrate_x_sq.cc]</kbd> Integrating $x^2$]
Expand Down Expand Up @@ -406,8 +404,6 @@
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++

int main() {
int inside_circle = 0;
int inside_circle_stratified = 0;
int N = 1000000;
auto sum = 0.0;
for (int i = 0; i < N; i++) {
Expand Down Expand Up @@ -439,8 +435,6 @@
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++

int main() {
int inside_circle = 0;
int inside_circle_stratified = 0;
int N = 1000000;
auto sum = 0.0;
for (int i = 0; i < N; i++) {
Expand Down Expand Up @@ -484,8 +478,6 @@
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++

int main() {
int inside_circle = 0;
int inside_circle_stratified = 0;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
int N = 1;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
Expand Down