Inline clean #813
Merged
Inline clean #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are declared as static, so the `inline` keyword is unnecessary as a definition-per-translation-unit modifier. Defer to the compiler for a possible performance optimization.
Our quick and dirty illustration programs had a bunch of helper functions in main.cc with the `inline` keyword. These are unnecessary.
This function was an inline global defined in `pdf.h`. Moved it to a private method on class `sphere`, called only from `sphere::random()`.
There were multiple copies of the `random_cosine_direction()` utility function in the cos_density.cc program and also in the `pdf.h` header. Moved this function to `vec3.h` where it belongs.
|
What's your plan with this PR here? Move all member functions into the class definition, |
|
Yes, exactly. Trying to roll this out incrementally. I'm trying to avoid hairballs so it's easier to review. |
trevordblack
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite comments in #803, we still had multiple cases where
inlinekeywords were not required or where there was a better location for many of these global functions. Simple cleanup pass of different cases.