Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uniform sampling #934

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

spkersten
Copy link
Contributor

@spkersten spkersten commented Sep 26, 2021

Now, the image with uniform PDF has indeed more noise:

cosine PDF uniform PDF
cosine-pdf uniform-pdf

Both images are made with 100 samples per pixel and 600x600 pixels.

Fixes #932
Fixes #933

@spkersten spkersten changed the base branch from master to dev-major September 26, 2021 10:13
@trevordblack trevordblack merged commit 88f6dae into RayTracing:dev-major Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Book 3: Not actually sampling from uniform PDF Book 3: Cosine calculated incorrectly
2 participants