Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockscreen doesn't appear right away after waking the computer from sleep #174

Closed
smartlitchi opened this issue Jul 16, 2020 · 11 comments
Closed
Labels

Comments

@smartlitchi
Copy link

smartlitchi commented Jul 16, 2020

This issue is a....

[x] Bug
[ ] Other kind of issue (Please describe in detail)

Current Behavior

After an update from 2.12.c.1 to 2.12.c.2, I can see my screen when the laptop wakes up from sleep. The lockscreen only appears after I begin typing my password.

Expected Behavior

Before the update, when the laptop was waking up from sleep, I could see the lockscreen right away

Reproduction Instructions

  • update to i3lock-color v2.12.c.2
  • set xset s off dpms 5 for the sleep function to kick in after 5 seconds of inactivity

Environment

Output of i3lock --version:

i3lock: version 2.12.c.2 (2020-04-18) © 2010 Michael Stapelberg, © 2015 Cassandra Fox

Where'd you get i3lock-color from?

[ ] AUR package (which one?)
[ ] Built from source yourself
[x] Other (Please describe in detail)

I modified the Arch official PKGBUILD to build the commit I wanted

@Raymo111
Copy link
Owner

How are you running i3lock after wake?

@smartlitchi
Copy link
Author

in my i3 config, I have exec --no-startup-id xss-lock -l screenlock.sh and here is the content of screenlock.sh

wallpaper=$HOME/PathToWallpaper.png
i3lock --pass-media-keys --pass-screen-keys -n -t -i $wallpaper \
    --insidecolor=72bfb900 --ringcolor=000000ff --line-uses-inside \
    --keyhlcolor=d23c3dff --bshlcolor=d23c3dff --separatorcolor=00000000 \
    --insidevercolor=fecf4dff --insidewrongcolor=d23c3dff \
    --ringvercolor=ffffffff --ringwrongcolor=ffffffff --indpos="50:573"\
    --ring-width=2 \
    --radius=12 --veriftext="" --wrongtext="" --noinputtext=""

@Raymo111
Copy link
Owner

@zimawho try https://gist.github.com/Raymo111/91ffd256b7aca6a85e8a99d6331d3b7b instead of xss-lock.

@smartlitchi
Copy link
Author

I tried your systemd solution to no avail so I built every commit from 2.12.c.1 to 2.12.c.2. The bug seems to be introduced by commit 5a7e156 which makes little sense because it barely changed i3lock.1 file. I am going to investigate a bit further

@Raymo111
Copy link
Owner

Have you tried using the git version from AUR? I've tried many times to get @AladW to update to the latest version (and even applied for TU status) but to no avail. The community PKGBUILD is SEVERELY out of date and I don't like that one bit :/

@smartlitchi
Copy link
Author

smartlitchi commented Jul 17, 2020

The community PKGBUILD is on latest release (2.12.c.4) so not really out of date anymore. It's an orphan package now though, so maybe you could try to apply again and maintain it. I also tried the AUR package and it has the same bug

@AladW
Copy link

AladW commented Jul 18, 2020

Sorry for the lack of communication, I've started my MSc and I have close to 0 time for Arch stuff. Good someone else updated it, though.

@Raymo111
Copy link
Owner

@zimawho unfortunately I have been told, quite angrily, that I am ineligible for TU status right now. Try building the latest version from git and seeing if the problem still exists?

@smartlitchi
Copy link
Author

The bug is still present after building latest version from git but not present when building i3lock from upstream ...

@Zebradil
Copy link

Zebradil commented Sep 4, 2020

I have no issues with locking before my system is going to sleep, while using i3lock-color-git from AUR (current version is r736.b2c1024-2) with the following systemd service:

[Unit]
Description=Lock screen on suspend
Before=sleep.target suspend.target hibernate.target hybrid-sleep.target

[Service]
User=%I
Environment=DISPLAY=:0
Type=forking
ExecStart=/home/%I/bin/systemd-lock
ExecStartPost=/usr/bin/sleep 1

[Install]
WantedBy=sleep.target suspend.target hibernate.target hybrid-sleep.target

systemd-lock contains only i3lock invocation with some theming arguments.

SebTM added a commit to betterlockscreen/betterlockscreen that referenced this issue May 28, 2021
Besides user-feedback I've found many resources showing that it is one common way to use forking here.
I've also found the option "--nofork" for i3lock-color but I'm unsure of the side-effects (i3/i3lock#109)
as it was the less popular solution.

https://gist.github.com/victorhaggqvist/603125bbc0f61a787d89
Raymo111/i3lock-color#174 (comment)
https://gist.github.com/Raymo111/91ffd256b7aca6a85e8a99d6331d3b7b
SebTM added a commit to betterlockscreen/betterlockscreen that referenced this issue May 28, 2021
Besides user-feedback I've found many resources showing that it is one common way to use forking here.
I've also found the option "--nofork" for i3lock-color but I'm unsure of the side-effects (i3/i3lock#109)
as it was the less popular solution.

https://gist.github.com/victorhaggqvist/603125bbc0f61a787d89
Raymo111/i3lock-color#174 (comment)
https://gist.github.com/Raymo111/91ffd256b7aca6a85e8a99d6331d3b7b
SebTM added a commit to betterlockscreen/betterlockscreen that referenced this issue May 28, 2021
Besides user-feedback I've found many resources showing that it is one common way to use forking here.
I've also found the option "--nofork" for i3lock-color but I'm unsure of the side-effects (i3/i3lock#109)
as it was the less popular solution.

https://gist.github.com/victorhaggqvist/603125bbc0f61a787d89
Raymo111/i3lock-color#174 (comment)
https://gist.github.com/Raymo111/91ffd256b7aca6a85e8a99d6331d3b7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants