Also pass XF86 Power Off and Power Down keys through when using --pass-media-keys #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I'm for passing these two keys, I'd rather do this one of two ways:
The main reasons being that the power key(s) aren't really media keys, and it changes the meaning of the existing arg. (I think the former option isn't as great, since it would also inherently mean removing the current arg & also impacts existing workflows). Otherwise looks good. |
|
How about we make 3 separate options?
|
|
Sounds good. I'd forgotten that the brightness keys were passed too. |
|
Ok, I've made it work. |
PandorasFox
reviewed
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it very annoying that I have to unlock before I can sleep my computer. This should not have any additional security risks than the other media keys.