Shell command options for media keys

[jclds139]

Closes #136

Description

Enables options to provide a shell command to run for each of the keys that could be passed by --pass-*-keys.
A master option, --custom-key-commands enables all of the others, then each of --*-cmd corresponds to a single keysym, taking a shell command to run when that key is pressed.

This could look like a security hole, but it realistically should be no more dangerous than the existing --pass-*-keys options, which let the root window do whatever it wants in responds to the keypress.

Release notes

Notes: Enables custom shell commands to handle media, power, screen, and volume keys as an alternative to passing them to the root window.

[JezerM]

I suggest to change the naming to cmd-**-** for a better scheme, which might help to find these commands faster, like --cmd-brightness-up and --cmd-power-off.

This feature could be insecure, but yet it's opt to the user to take the risk and make sure it works with their environment. It's simpler and better than my previous solution.

[jclds139]

Good point! Done. Do you want the commits squashed together?

edit: apologies for accidentally closing the PR when commenting

[jclds139]

Is this acceptable? I tried to keep different key types to their own block of 10.

[JezerM]

Looks good to me~

[Raymo111]

@jclds139 @JezerM I can't get it to work? I'm running

./build.sh -d
LD_PRELOAD= ./build/i3lock --no-verify --cmd-volume-up="touch /tmp/success"

i3lock triggers correctly, but when I press the volume up key, no file is created.

[JezerM]

You're forgetting the --custom-key-commands flag to enable those commands.

[Raymo111]

You're forgetting the --custom-key-commands flag to enable those commands.

Thanks, I was being dumb :p

[Raymo111]

Just a quick thing about strdup, everything else looks great and it works very nicely!

[Raymo111]

Couple last things

[Raymo111]

LGTM, thanks for contributing!