Wheee, fix forecast problem in issue #4 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe you'll disagree with my changes in the ->> area; if so just add unescape to the end of the original chain.
… had the effect of combining 3+ blank lines into only 2, but that's probably not such a bad thing.
For future reference, the script was:
find -name '*.clj' | xargs perl -i -e '$/="" ; while (<>) {s/\s*\n\s*([])}]+)/$1/s; print;}'
|
Ummm, I don't understand why it's automatically adding everything I push into this pull request. I'd like 0e5d pulled, but it's not related to this issue at all; if I knew how I'd move it to another pull request. |
|
In the future, create new git branches for new features and bug fixes, and then add pull requests for that branch. Whenever you issue a pull request, any commits added to that branch are added to the pull request. I didn't use reduce for in nil-comp because I didn't want it doing unnecessary computation. However, at the time I wrote that, I didn't know about the Otherwise, excellent work! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, it seems to have added a merge commit, which ought to already be in your repo? I don't really know why it wants you to include that guy in the pull.