Removed special casing of HTTP headers and request options #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not following this pull request. We're deleting a bunch of code. How does that work? What are we doing? |
|
The idea is to use the middleware capabilities in newer versions of |
|
Closing because it has been a year and I don't think a ton of value would be added by trying to resolve the merge conflicts. Sorry, I've been out of the clj game for quite a while and am just catching up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not suggesting this is ready to be merged yet, but I'm interested in your opinion if you have a chance to take a look. Am I on the right track? For now I removed the broken test since it doesn't really make sense anymore, but of course more tests should be added. Also I should probably add a
with-all-pagesmacro so the user doesn't need to modify*all-pages*directly.