Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposes the real engine.io server from the attach method (as it does in the main fork) so that clients and clientsCount can be exposed #14

Merged
merged 2 commits into from
Jan 13, 2014

Conversation

heapwolf
Copy link
Collaborator

Before submitting this PR I ran the tests and noticed the following (possibly unrelated) message on Darwin dev04.local 13.0.0 Darwin Kernel Version 13.0.0: Thu Sep 19 22:22:27 PDT 2013; root:xnu-2422.1.72~6/RELEASE_X86_64 x86_64 Running node v0.10.18 with npm 1.3.8.

➜ engine.io-stream git:(master) ✗>npm test

> engine.io-stream@0.4.2 test /Users/paolo/workroot/git/hij1nx/engine.io-stream
> zuul -- test/index.js

  - all passed

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: getaddrinfo ENOTFOUND
    at errnoException (dns.js:37:11)
    at Object.onanswer [as oncomplete] (dns.js:124:16)
    at Socket.recon_local (/Users/paolo/workroot/git/hij1nx/engine.io-stream/node_modules/zuul/node_modules/localtunnel/client.js:76:23)
    at Socket.g (events.js:175:14)
    at Socket.EventEmitter.emit (events.js:92:17)
    at Object.afterConnect [as oncomplete] (net.js:883:10)
npm ERR! weird error 8

…in the main fork) so that `clients` and `clientsCount` can be exposed
Raynos added a commit that referenced this pull request Jan 13, 2014
exposes the real engine.io server from the attach method (as it does in the main fork) so that `clients` and `clientsCount` can be exposed
@Raynos Raynos merged commit 6848848 into Raynos:master Jan 13, 2014
@Raynos
Copy link
Owner

Raynos commented Jan 13, 2014

Published v0.4.3

@Raynos
Copy link
Owner

Raynos commented Jan 13, 2014

As for the failing test, I don't use this module in production any more so I can't really maintain it properly.

npm test passes for me locally.

@heapwolf
Copy link
Collaborator Author

I figured it would, you are on linux, right?

@Raynos
Copy link
Owner

Raynos commented Jan 13, 2014

I'm on ubuntu. This could be a darwin zuul bug @defunctzombie

@defunctzombie
Copy link
Collaborator

I just bumped the minimum required zuul and also ran tests on my mac and it worked fine.

@hij1nx if you want to test locally use zuul --local -- test/*.js

@Raynos can you add this repo to travis-ci and then I will add the keys needed to test this in saucelabs

@Raynos
Copy link
Owner

Raynos commented Jan 13, 2014

@defunctzombie I added it to travis, hopefully it runs soon.

@heapwolf
Copy link
Collaborator Author

@defunctzombie 👍 works great with zuul --local -- test/*.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants