Update readme #13
Merged
Update readme #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable badges Gemnasium has been closed since it was acquired by GitLab, thus it is removed. The build and coverage links don't work, but that might be caused by an configuration issue, so they are left as disabled for now. https://docs.gitlab.com/ee/user/project/import/gemnasium.html Update wording regarding phantomjs support While old version does not support Function.prototype.bind, the latest (2.1.1) does. Phantomjs is also no longer in development, so it's safe to assume it will stay the same. Even if it becomes active, it most likely won't go back to an older, unsupporting, version of QT/WebKit. http://phantomjs.org/release-2.1.html ariya/phantomjs#15344
ljharb
requested changes
Feb 16, 2019
|
I've applied your suggestions now. |
ljharb
force-pushed
the
maxnordlund-update-readme
branch
2 times, most recently
from
4f1ce73
to
503cb12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things, and if you don't like one of the changes they can easily be rebased away.
1, It reenables the most of the badges.
2, It updates the wording regarding phantomjs support for Function.prototype.bind
The commit messages contains more info and links.