Moving module.exports to the top level #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Apr 17, 2017
Raynos
reviewed
Apr 17, 2017
document.js
Outdated
| @@ -3,13 +3,13 @@ var topLevel = typeof global !== 'undefined' ? global : | |||
| var minDoc = require('min-document'); | |||
|
|
|||
| if (typeof document !== 'undefined') { | |||
| module.exports = document; | |||
| var doccy = document; | |||
There was a problem hiding this comment.
nit: please declare var doccy outside the if statement
window.js
Outdated
| @@ -1,9 +1,11 @@ | |||
| if (typeof window !== "undefined") { | |||
| module.exports = window; | |||
| var win = window; | |||
There was a problem hiding this comment.
nit: please declare var win outside the if statement.
|
@Raynos I fixed the nits. |
|
Merged, will publish new version. If I forget ping me :) (on phone) |
|
@Raynos Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using a Rollup plugin which converts CommonJS to ES6 modules.
It does this by converting
module.exports = foo;intoexport default foo;However, this only works if the
module.exportsis at the top level, because ES6 requires all exports to be at the top level.This pull request moves the
module.exportsto the top level, so that it will work with my plugin.