Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You're forked ;-) #15

Open
kuraga opened this issue May 6, 2015 · 5 comments
Open

You're forked ;-) #15

kuraga opened this issue May 6, 2015 · 5 comments

Comments

@kuraga
Copy link

kuraga commented May 6, 2015

https://github.com/kuraga/vnode-immutable-thunk

@neonstalwart
Copy link

it's not a problem, but why? what was missing/broken/... here?

@kuraga
Copy link
Author

kuraga commented May 6, 2015

No, no. It's not an opposition, don't you you see smile in title? 😄

I'm working on https://github.com/kuraga/rotorjs-concept and there are some features I want to introduce which are doubtful for this package.

Now differences are custom args and renders equality functions.

P.S. It's just an advertise, feel free to close.

@neonstalwart
Copy link

i realize it's friendly but i was just curious what was not flexible enough or was missing from here for you. i see now what some of the differences are.

btw, you don't include a way to provide a key. you're missing a potentially significant optimization by not allowing for a key.

@kuraga
Copy link
Author

kuraga commented May 6, 2015

Why not? Just use proto argument. I just unified this (but, maybe, in bad-way manner)

@neonstalwart
Copy link

i see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants