Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default template should make use of returnUrl parameter upon login #128

Closed
apexdodge opened this issue Jul 2, 2023 · 0 comments
Closed

Default template should make use of returnUrl parameter upon login #128

apexdodge opened this issue Jul 2, 2023 · 0 comments
Assignees
@apexdodge
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
v1.1.1

Comments

@apexdodge
Copy link
Contributor

The problem is that user's not being redirected to their destination upon login if returnUrl is specified as a URL parameter. You can fix this manually in your Raytha template, but we should fix the default template.

raytha/src/Raytha.Domain/Entities/DefaultTemplates/raytha_html_login_emailandpassword.liquid

Line 11 in bc96ab7

action="{{ PathBase }}/account/login"

Line should be fixed to:

{{ PathBase }}/account/login?returnUrl={{ Target.ReturnUrl }}
@apexdodge apexdodge added bug Something isn't working good first issue Good for newcomers labels Jul 2, 2023
@apexdodge apexdodge added this to the v1.1.1 milestone Jul 2, 2023
@apexdodge apexdodge self-assigned this Jul 7, 2023
apexdodge added a commit that referenced this issue Jul 7, 2023
@apexdodge
Applies returnUrl for login on default template #128
25cf6b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apexdodge apexdodge

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
1 participant
@apexdodge