Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated Dockerfile commands #158

Closed
apexdodge opened this issue Dec 9, 2023 · 1 comment
Closed

Update deprecated Dockerfile commands #158

apexdodge opened this issue Dec 9, 2023 · 1 comment
Labels
good first issue Good for newcomers
Milestone

Comments

@apexdodge
Copy link
Contributor

These commands in the current Dockerfile for node installation are deprecated and a large warning appears when docker is building the image.

RUN apt install -y curl

Should be replaced with:

RUN apt update
RUN apt install -y curl ca-certificates curl gnupg
RUN mkdir -p /etc/apt/keyrings
RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
RUN echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_16.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list
RUN apt update
RUN apt install -y nodejs
@apexdodge apexdodge added the good first issue Good for newcomers label Dec 9, 2023
@apexdodge apexdodge added this to the v1.1.4 milestone Dec 9, 2023
apexdodge added a commit that referenced this issue Dec 10, 2023
@apexdodge
Copy link
Contributor Author

Will be released with v1.1.4.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant