Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes #152

Merged
merged 4 commits into from Dec 6, 2023
Merged

Minor bug fixes #152

merged 4 commits into from Dec 6, 2023

Conversation

brendonofficial
Copy link
Contributor

This PR fixes some minor code issues that I had noticed when cloning the repository.

Additionally, adding .idea to gitignore for those Rider users out there 馃槑

@brendonofficial brendonofficial changed the base branch from main to dev November 23, 2023 13:05
@apexdodge
Copy link
Contributor

Thank you very much for your contribution. The one thing I am not sure of is asp-action vs asp-page. asp-action seems to work well. Is there a bug you noticed?

@brendonofficial
Copy link
Contributor Author

@apexdodge ah, my apologies, this is supposed to be asp-route not asp-page. I have updated the PR.

Using asp-route here follows in line with other references to named routes within the codebase. Alternatively, asp-controller="EmailTemplates" asp-action="Index" would be used instead, but asp-action="EmailTemplatesIndex" won't work here as there is no such controller action named the same.

@apexdodge apexdodge merged commit 6ce4919 into RaythaHQ:dev Dec 6, 2023
@apexdodge
Copy link
Contributor

@brendonofficial Thank you for your contribution! This will be released with v1.1.4.

@brendonofficial brendonofficial deleted the fix/minor-bug-fixes branch December 8, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants