Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of QStringRef by QStringView #2

Merged
merged 1 commit into from
May 4, 2021
Merged

Replace usage of QStringRef by QStringView #2

merged 1 commit into from
May 4, 2021

Conversation

Arthapz
Copy link
Contributor

@Arthapz Arthapz commented Jan 13, 2021

No description provided.

@Arthapz Arthapz mentioned this pull request Jan 13, 2021
Closed
@Razakhel Razakhel self-requested a review January 13, 2021 16:59
@Razakhel Razakhel self-assigned this Jan 13, 2021
Razakhel
Razakhel reviewed Jan 13, 2021
View reviewed changes
Copy link
Owner

@Razakhel Razakhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR, if you could just squash those commits that would be awesome!

@Razakhel Razakhel force-pushed the master branch 2 times, most recently from 81af599 to 434c149 Compare January 15, 2021 00:08
@Razakhel Razakhel merged commit cc41a56 into Razakhel:master May 4, 2021
@Razakhel Razakhel linked an issue May 4, 2021 that may be closed by this pull request
Use QStringView instead of QStringRef #1
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razakhel Razakhel Razakhel left review comments

Assignees

@Razakhel Razakhel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use QStringView instead of QStringRef
2 participants
@Arthapz @Razakhel