Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit tests #3

Closed
Razdeep opened this issue Oct 7, 2020 · 6 comments
Closed

Add Unit tests #3

Razdeep opened this issue Oct 7, 2020 · 6 comments
Labels

Comments

@Razdeep
Copy link
Owner

Razdeep commented Oct 7, 2020

Using google-test write unit tests for the project.
The GTest project should be built as an ExternalProject in cmake.
Do not add GTest as a submodule or insert the project files directly.

@ollelogdahl
Copy link
Contributor

ollelogdahl commented Oct 7, 2020

Hello. I want to contribute to this! :) Working on it now

@Razdeep
Copy link
Owner Author

Razdeep commented Oct 7, 2020

Great!
GTest should be downloaded & built once if a flag like -DBUILD_TEST=ON is provided along with the CMake command.

@ollelogdahl
Copy link
Contributor

Having some problems compiling the source. splitwebp.cpp requires fstream (std::fstream is defined in fstream). I will replace the iostream include for the fstream, since fstream itself includes iostream. Linux also requires hdl5 installed separately (dependency of libopencv_hdl), and therefore i have added it in the dependency list in README. I will add this in my final commit :)

@ollelogdahl
Copy link
Contributor

Im still intrested in making actual tests for the project, if someone else has the experience to set up the correct environment.

@Razdeep
Copy link
Owner Author

Razdeep commented Oct 7, 2020

Did you manage to compile the source on Linux? What distribution are you using? And what is the opencv version that you have downloaded?

For now, you can install GTest globally (using a package manager like apt-get), and write the tests. Later on, we'll figure out a way to use GTest as ExternalProject.

@ollelogdahl
Copy link
Contributor

Using Archlinux. It compiled sucessfully, once i manually installed hdl5 and fixed the include error. Using openCV 4.4.
I will go ahead and write some tests, compiling them globally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants