Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up blpapi utils #127

Merged
merged 3 commits into from
Feb 10, 2016
Merged

Clean up blpapi utils #127

merged 3 commits into from
Feb 10, 2016

Conversation

armstrtw
Copy link
Contributor

cleanup to move new util functions into blpapi_utils.cpp and move Lazyframe related code into bds which is the only remaining place it's used.

@eddelbuettel
Copy link
Member

Great idea -- til we figure out how to totally avoid it, at least make it local.

eddelbuettel added a commit that referenced this pull request Feb 10, 2016
@eddelbuettel eddelbuettel merged commit 460d89f into master Feb 10, 2016
@armstrtw armstrtw deleted the clean-up-blpapi-utils branch February 10, 2016 18:59
@RockScience
Copy link

is #107 also an issue linked to Lazyframe?

@armstrtw
Copy link
Contributor Author

Well, this is the fieldInfo from BBG for LAST_UPDATE:

id "PR024"
mnemonic "LAST_UPDATE"
datatype "Datetime"
ftype "DateOrTime"

So, we can address this in the new allocateDataFrame function. The problem is that most of the functions (bdp, bdh) still use populateDfRow to convert the bbg response to a dataframe, and that code still uses the BBG types to convert, so it's going to see BLPAPI_DATATYPE_DATE or BLPAPI_DATATYPE_TIME and that particular function assumes that the allocation function has already set up for a double (posix) or integer (date).

So, there's still some work to be done to connect the types we see at allocation time w/ the populateDfRow function. I don't think it's too hard, but just going to take some time to re-tool for this.

@RockScience
Copy link

Thank you for the detailed explanation, it is much more clear now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants