Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Rcpp vignette style #153

Merged
merged 2 commits into from Aug 1, 2017
Merged

use Rcpp vignette style #153

merged 2 commits into from Aug 1, 2017

Conversation

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Jul 31, 2017

@binxiangni I updated the vignette a little, see a (temp) copy of the pdf for a quick glance.

@binxiangni
Copy link
Contributor

@binxiangni binxiangni commented Aug 1, 2017

Looks good. There might be an inconsistency due to me. Subsection 2.7.3 includes library(Matrix), but others don't. Maybe we can just remove it. The other part is great. You can merge it. Thank you!

@eddelbuettel
Copy link
Member Author

@eddelbuettel eddelbuettel commented Aug 1, 2017

Maybe we can just remove it.

Done!

@eddelbuettel
Copy link
Member Author

@eddelbuettel eddelbuettel commented Aug 1, 2017

BTW, one downside is that you need a helper script such as the snippet below to compile the vignette.

#!/usr/bin/Rscript

## use given argument(s) as target files, or else default to .Rnw files in directory
files <- if (length(commandArgs(TRUE)) == 0) dir(pattern="*.Rnw") else commandArgs(TRUE)

## convert all files from Rnw to pdf using the highlight driver
invisible(sapply(files, function(srcfile) {
    Sweave(srcfile, driver=highlight::HighlightWeaveLatex())
    tools::texi2pdf(gsub(".Rnw", ".tex", srcfile))
}))
@eddelbuettel eddelbuettel merged commit 1779ced into master Aug 1, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@binxiangni
Copy link
Contributor

@binxiangni binxiangni commented Aug 1, 2017

Not familiar with that. I just compile my original one in Rstudio. Thanks for reminding. Really learned a lot from you this summer.

@eddelbuettel
Copy link
Member Author

@eddelbuettel eddelbuettel commented Aug 1, 2017

It's the non-standard (but perfectly fine and permitted) vignette engine we use: based on highlight. All pretty easy on Linux, and (I presume) possible on macOS...

@eddelbuettel eddelbuettel deleted the feature/vignette-polish branch Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.