New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with .registration=TRUE, change C++ fastLm to fastLm_impl (closes #163) #164

Merged
merged 1 commit into from Aug 19, 2017

Conversation

Projects
None yet
3 participants
@eddelbuettel
Member

eddelbuettel commented Aug 19, 2017

No description provided.

@eddelbuettel eddelbuettel requested review from thirdwing and removed request for thirdwing Aug 19, 2017

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Aug 19, 2017

Member

Poking (informally) at @thirdwing @binxiangni @coatless @kevinushey to have a look with a second set of eyes before I merge...

Member

eddelbuettel commented Aug 19, 2017

Poking (informally) at @thirdwing @binxiangni @coatless @kevinushey to have a look with a second set of eyes before I merge...

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Aug 19, 2017

Member

Thank you both.

Member

eddelbuettel commented Aug 19, 2017

Thank you both.

@eddelbuettel eddelbuettel merged commit 8de0226 into master Aug 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel referenced this pull request Aug 19, 2017

Closed

Build Error #163

@eddelbuettel eddelbuettel deleted the bugfix/registration branch Aug 21, 2017

michaelweylandt added a commit to michaelweylandt/RcppEigen that referenced this pull request May 30, 2018

Update call to RcppArmadillo_fastLm_impl
- RcppArmadillo's underlying implementation of
  fastLm was renamed to fastLm_impl in
  RcppCore/RcppArmadillo#164 (mid-August 2017)

michaelweylandt added a commit to michaelweylandt/RcppEigen that referenced this pull request May 30, 2018

Update call to RcppArmadillo_fastLm_impl
- RcppArmadillo's underlying implementation of
  fastLm was renamed to fastLm_impl in
  RcppCore/RcppArmadillo#164 (mid-August 2017)
- Call the RcppAttributes generated C++
  function directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment