Armadillo 8.100, call .sync() before accessing the internal arrays of the SpMat class

[binxiangni]

I just call .sync() in as<>() and it works. But it seems a little weird that no error comes out when I don't call .sync() in wrap() before reading those internal arrays of the SpMat class.

[eddelbuettel]

Your tests may be missing the salient fact that we are not on Armadillo 0.8[01]00.* yet.

But it is good that you are proactive and on top of this.

[binxiangni]

So in addition to copying armadillo & armadillo_bits to here and modifying as<>(), what else should I do?

[binxiangni]

I find that I don't need to call .sync() before arma::access::rwp, but I should call that before arma::access::rw, which possibly means no need to call .sync() before directly reading or writing the pointers. I guess that might explain my problem.

[eddelbuettel]

So in addition to copying armadillo & armadillo_bits to here and modifying as<>(), what else should I do?

I think you can wait for more tests until I had a chance to update Armadillo within RcppArmadillo.

[eddelbuettel]

I am now (at last) at Armadillo 8.100.1. I think I will need the first part of the PR -- as there are some errors -- but there are "issues" with this PR as it covers 80+ files it should not cover (from Armadillo 8.*). Shall we / can we clean that up, or shall I just re-apply the relevant part by hand?

[eddelbuettel]

(Copying over. Wrote this in #175 by mistake at first.)

This was a very important and timely PR. I had test failures due to SpMat changes, but with your syncing it passes.

Now it so happens that I cannot merge this now, but I will give you full credit in inst/NEWS.Rd. Hope that's ok.

I should have put 8.100.* into a branch earlier. My bad.

[eddelbuettel]

Ok, I folded this into #176 which is now being tested.

[binxiangni]

Sorry for being late to take action. Being busy with midterms. Kind of difficult to catch you up. So what should I do? As I see, you've removed the redundant files, right?

[eddelbuettel]

No real action item. But if you and @sgsokol can look over the changes I made to RcppArmadilloAs.h in the branch that is behind the #176 PR. It is now running a rev.dep -- we should be good.

[binxiangni]

I checked it and my part should be fine. Thanks! (btw, the PR number above should be #176 )

[eddelbuettel]

Ooops. Correcting.

[sgsokol]

For me too, it looks OK.

[eddelbuettel]

Again, sorry to both of for sitting on the PRs in a way that then prevented me from merging them.

Lesson learned, I just should not wait for my next RcppArmadillo release cycle.

[eddelbuettel]

The content of this PR is now in master via #176. Again my apologies for not merging this sooner (maybe into a branch with arma 8.*).