Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Armadillo 8.100, call .sync() before accessing the internal arrays of the SpMat class #171
I am now (at last) at Armadillo 8.100.1. I think I will need the first part of the PR -- as there are some errors -- but there are "issues" with this PR as it covers 80+ files it should not cover (from Armadillo 8.*). Shall we / can we clean that up, or shall I just re-apply the relevant part by hand?
(Copying over. Wrote this in #175 by mistake at first.)
This was a very important and timely PR. I had test failures due to SpMat changes, but with your syncing it passes.
Now it so happens that I cannot merge this now, but I will give you full credit in inst/NEWS.Rd. Hope that's ok.
I should have put 8.100.* into a branch earlier. My bad.